KS-129: Implement modify DON #13242
Merged
KS-129: Implement modify DON #13242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds95
requested review from
archseer,
bolekk,
patrick-dowell and
a team
as code owners
cds95
commented
May 17, 2024
cds95
force-pushed
the
KS-129/implement-modify-DON-capability-registry
branch
from
203e604 to
251d23f
Compare
cds95
commented
May 17, 2024
| s_dons[donId].isPublic = isPublic; | ||
|
|
||
| DONCapabilityConfig storage donCapabilityConfig = s_dons[donId].config[configCount]; | ||
| for (uint256 i; i < nodes.length; ++i) { |
There was a problem hiding this comment.
Thinking a bit on how to optimize this. Currently the code blindly updates the DON's nodes and supported capability configs even if the function parameters are the same as what's already in storage. One idea I had was to store the hash of nodes and capabilityConfigs and compare them against the hash of the params passed in.
There was a problem hiding this comment.
Create a ticket to test this out during the gas optimization stage?
DeividasK
reviewed
May 17, 2024
Comment on lines
565
to
566
| uint32 configCount = 1; // Initialize config count to start at 1 | ||
| _setDONConfig(id, configCount, nodes, capabilityConfigurations, isPublic); |
There was a problem hiding this comment.
Suggested change
| uint32 configCount = 1; // Initialize config count to start at 1 | |
| _setDONConfig(id, configCount, nodes, capabilityConfigurations, isPublic); | |
| _setDONConfig(id, 1, nodes, capabilityConfigurations, isPublic); |
DeividasK
approved these changes
May 17, 2024
|
cds95
merged commit 9e3d804
into
use-encode-instead-of-encode-packed-capability-id
117 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.